Since ath10k commit 37ff1b0df37a ("ath10k: clean header files from bad block
comments", going to 4.12) ath10k has been cleaned with all block comment
issues. So now we can enable the checkpatch warning.
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
This is for running optional checks which we haven't fixed yet or might be
false positive. Currently enables only W=1 for kernel.
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
By default the script now does not show any warnings outside ath directory, but
with --no-filter that can be disabled:
$ ath10k-check
$ ath10k-check --no-filter
./arch/x86/include/asm/uaccess.h:714:18: warning: incorrect type in argument 1 (different modifiers)
./arch/x86/include/asm/uaccess.h:714:18: expected void *<noident>
./arch/x86/include/asm/uaccess.h:714:18: got void const *from
./include/linux/relay.h:209:16: warning: incorrect type in initializer (different address spaces)
./include/linux/relay.h:209:16: expected void const [noderef] <asn:3>*__vpp_verify
./include/linux/relay.h:209:16: got struct rchan_buf **<noident>
$
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Hopefully this is now easier for people to use. Also use nproc to get the
number of cores available.
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Add a script for installing firmware images from ath10k-firmware.git
repository and help with other firmware management related tasks.
usage: ath10k-fw-repo [-h] [--debug] [--dry-run] [--check] [--list]
[--install DESTINATION] [--unit-test]
Install firmware images from the ath10k-firmware git repository. Run it from
the top directory of the working tree.
optional arguments:
-h, --help show this help message and exit
--debug Enable debug messages.
--dry-run Do not run any actual commands.
--check Check the ath10k-firmware repository content for
validity.
--list List all files found from the ath10k-firmware
repository.
--install DESTINATION
Install all ath10k firmware images to DESTINATION
folder, for example /lib/firmware.
--unit-test Run unit tests for this script.
Screenshot:
$ ath10k-fw-repo --install /lib/firmware
Unknown file: QCA99X0/hw2.0/boardData_AR900B_CUS239_5G_v2_001.bin
Unknown file: QCA99X0/hw2.0/boardData_AR900B_CUS260_2G_v2_002.bin
Installing QCA9377/hw1.0/firmware-5.bin (WLAN.TF.1.0-00267-1)
Installing QCA9377/hw1.0/notice_ath10k_firmware-5.txt (WLAN.TF.1.0-00267-1)
Installing QCA9377/hw1.0/board.bin
Installing QCA9377/hw1.0/board-2.bin
Installing QCA988X/hw2.0/firmware-5.bin (10.2.4.70.54)
Installing QCA988X/hw2.0/notice_ath10k_firmware-5.txt (10.2.4.70.54)
Installing QCA988X/hw2.0/board.bin
Installing QCA4019/hw1.0/firmware-5.bin (10.4-3.2-00080)
Installing QCA4019/hw1.0/notice_ath10k_firmware-5.txt (10.4-3.2-00080)
Installing QCA4019/hw1.0/board-2.bin
Installing QCA9888/hw2.0/firmware-5.bin (10.4-3.2-00072)
Installing QCA9888/hw2.0/board-2.bin
Installing QCA9887/hw1.0/firmware-5.bin (10.2.4-1.0-00013)
Installing QCA9887/hw1.0/notice_ath10k_firmware-5.txt (10.2.4-1.0-00013)
Installing QCA9887/hw1.0/board.bin
Installing QCA99X0/hw2.0/firmware-5.bin (10.4.1.00030-1)
Installing QCA99X0/hw2.0/notice_ath10k_firmware-5.txt (10.4.1.00030-1)
Installing QCA6174/hw3.0/firmware-4.bin (WLAN.RM.2.0-00180-QCARMSWPZ-1)
Installing QCA6174/hw3.0/notice_ath10k_firmware-4.txt (WLAN.RM.2.0-00180-QCARMSWPZ-1)
Installing QCA6174/hw3.0/board-2.bin
Installing QCA6174/hw3.0/board.bin
Installing QCA6174/hw2.1/firmware-5.bin (SW_RM.1.1.1-00157-QCARMSWPZ-1)
Installing QCA6174/hw2.1/notice_ath10k_firmware-5.txt (SW_RM.1.1.1-00157-QCARMSWPZ-1)
Installing QCA6174/hw2.1/board.bin
Installing QCA6174/hw2.1/board-2.bin
Installing QCA9984/hw1.0/firmware-5.bin (10.4-3.2-00072)
Installing QCA9984/hw1.0/notice_ath10k_firmware-5.txt (10.4-3.2-00072)
Installing QCA9984/hw1.0/board-2.bin
$
* Register Modification for xLNA board.
* TX gain table modification for zero calibration.
* AUX chain (LNA2) sensitivity enhancement
* Modify diversity bias default setting in INI.
Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
This array has been introduced by commit
3b604b6cf811ba14e4c2bb3005e29bb2fba77af0
(ath9k_hw: INI changes for WoW for AR9002
chipsets) in linux, but it is not printed
from initvals.
Add it, and update ar9002_initvals.h and
checksums.txt.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
It is a dupe of 'ar9280PciePhy_clkreq_off_L1_9280', and
it is not used in ath9k. I forgot to remove it in commit
'qca-swiss-army-knife: fix build errors if ATH9K_DIR is used'
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
Some initval arrays were removed from ath9k with the
upstream commit 14fec8d9baffc026beaffa2ee9e911df9d1d4ad2
(ath9k_hw: remove duplicate initvals).
Due to the missing symbols, this causes build errors
when the ATHEROS Makefile variable is not set, and
an external ATH9K_DIR is specified:
$ make clean all ATH9K_DIR=/devel/wireless-testing/drivers/net/wireless/ath/ath9k
rm -f initvals
gcc -I"/devel/wireless-testing/drivers/net/wireless/ath/ath9k" -o initvals initvals.c sha1.c
initvals.c: In function ‘ar9001_hw_print_initvals’:
initvals.c:588:2: error: ‘ar5416Bank0_9100’ undeclared (first use in this function)
initvals.c:588:2: note: each undeclared identifier is reported only once for each function it appears in
initvals.c:589:2: error: ‘ar5416BB_RfGain_9100’ undeclared (first use in this function)
initvals.c:590:2: error: ‘ar5416Bank1_9100’ undeclared (first use in this function)
initvals.c:591:2: error: ‘ar5416Bank2_9100’ undeclared (first use in this function)
initvals.c:592:2: error: ‘ar5416Bank3_9100’ undeclared (first use in this function)
initvals.c:595:2: error: ‘ar5416Bank7_9100’ undeclared (first use in this function)
initvals.c:599:2: error: ‘ar5416Bank0_9160’ undeclared (first use in this function)
initvals.c:600:2: error: ‘ar5416BB_RfGain_9160’ undeclared (first use in this function)
initvals.c:601:2: error: ‘ar5416Bank1_9160’ undeclared (first use in this function)
initvals.c:602:2: error: ‘ar5416Bank2_9160’ undeclared (first use in this function)
initvals.c:603:2: error: ‘ar5416Bank3_9160’ undeclared (first use in this function)
initvals.c:604:2: error: ‘ar5416Bank6_9160’ undeclared (first use in this function)
initvals.c:605:2: error: ‘ar5416Bank6TPC_9160’ undeclared (first use in this function)
initvals.c:606:2: error: ‘ar5416Bank7_9160’ undeclared (first use in this function)
initvals.c: In function ‘ar9002_hw_print_initvals’:
initvals.c:597:2: error: ‘ar9285PciePhy_clkreq_always_on_L1_9285’ undeclared (first use in this function)
initvals.c:598:2: error: ‘ar9285PciePhy_clkreq_off_L1_9285’ undeclared (first use in this function)
initvals.c:605:2: error: ‘ar9285PciePhy_clkreq_always_on_L1_9285_1_2’ undeclared (first use in this function)
initvals.c:606:2: error: ‘ar9285PciePhy_clkreq_off_L1_9285_1_2’ undeclared (first use in this function)
initvals.c:613:2: error: ‘ar9287PciePhy_clkreq_always_on_L1_9287_1_1’ undeclared (first use in this function)
initvals.c:614:2: error: ‘ar9287PciePhy_clkreq_off_L1_9287_1_1’ undeclared (first use in this function)
initvals.c:617:2: error: ‘ar9271Common_normal_cck_fir_coeff_9271’ undeclared (first use in this function)
initvals.c:618:2: error: ‘ar9271Common_japan_2484_cck_fir_coeff_9271’ undeclared (first use in this function)
initvals.c:619:2: error: ‘ar9271Modes_9271_1_0_only’ undeclared (first use in this function)
make: *** [initvals] Error 1
$
Add definitions for the missing arrays to avoid
these compiler errors. Also introduce two new
macros and use those for printing the arrays.
After these changes, the initvals tool builds without
errors:
$ make clean all ATH9K_DIR=/devel/wireless-testing/drivers/net/wireless/ath/ath9k
rm -f initvals
gcc -I"/devel/wireless-testing/drivers/net/wireless/ath/ath9k" -o initvals initvals.c sha1.c
$
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
Due to the recent changes in AR9340 initvals,
checksums.txt needs to be updated.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
The number of the columns to be printed usually equals
with the actual columns. The only exceptions are the
Modes arrays, where the last column is not used by
ath9k.
The patch modifies the 'ath9k_get_p_columns' helper
so that can determine the correct number of columns
based on the name of the array. The the patch also
removes the 'wide' argument of various functions
because that is not necessary anymore. Additionaly,
the superfluous INI_PRINTW macro is removed as well.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
The number of the columns to be printed is computed in
two different function. Add a helper function for that
and remove the duplicated code.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
It is obsolete since the SHA1 checksums are used.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
The SLP32_MODE/INC registers have to be programmed with
values based on the ref. clock, which could be either 25MHz
or 40MHz. Incorrect values in these registers results in
TSF drift.
Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
Now that initvals supports the AR955X family,
refresh 'checksums.txt'.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
This is required for the QCA955X initvals, because that
contain some arrays with 9 columns.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
The current code contain lots of duplication in order to
print initval arrays for different families. Refactor the
code to get rid of the duplications. This makes the code
a bit clener, and adding support for a new family will be
easier as well.
Aslo update checksums.txt because the initvals for AR9462
are printed before AR9580.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
Keep the length of the macro lines under 80 character.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
Add the missing ar9340, ar9462-1p0, ar9565-1p0
families to the 'verify_checksums.sh' script.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
