mirror/openwrt
1
0
Fork 1
mirror of https://git.openwrt.org/openwrt/openwrt.git synced 2026-01-28 03:37:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

realtek: phy: replace hard coded pages 30/31 with define

Browse source 
Some of the code forgot to use the register defines for page
selection. Replace the hard coded values with their define.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/21716
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This commit is contained in:
Markus Stockhausen 2026-01-26 14:34:07 +01:00 • committed by Hauke Mehrtens
parent c2a3871387
commit 38fea332d9
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.c
View file

@ -127,18 +127,18 @@ static int rtl821x_match_phy_device(struct phy_device *phydev)
* during detection.
*/
oldpage = mdiobus_read(bus, addr, 0x1f);
oldxpage = mdiobus_read(bus, addr, 0x1e);
oldpage = mdiobus_read(bus, addr, RTL821x_PAGE_SELECT);
oldxpage = mdiobus_read(bus, addr, RTL821x_EXT_PAGE_SELECT);
mdiobus_write(bus, addr, 0x1e, 0x8);
mdiobus_write(bus, addr, 0x1f, 0x278);
mdiobus_write(bus, addr, RTL821x_EXT_PAGE_SELECT, 0x8);
mdiobus_write(bus, addr, RTL821x_PAGE_SELECT, 0x278);
mdiobus_write(bus, addr, 0x12, 0x455);
mdiobus_write(bus, addr, 0x1f, 0x260);
mdiobus_write(bus, addr, RTL821x_PAGE_SELECT, 0x260);
chip_mode = mdiobus_read(bus, addr, 0x12);
dev_dbg(&phydev->mdio.dev, "got RTL8218B/RTL8214Fx chip mode %04x\n", chip_mode);
mdiobus_write(bus, addr, 0x1e, oldxpage);
mdiobus_write(bus, addr, 0x1f, oldpage);
mdiobus_write(bus, addr, RTL821x_EXT_PAGE_SELECT, oldxpage);
mdiobus_write(bus, addr, RTL821x_PAGE_SELECT, oldpage);
/* no values while reading the 5th port during 5-8th port detection of RTL8218B */
if (!chip_mode)