From 38fea332d9fd805bc13a7ebc20c6d23c4e105532 Mon Sep 17 00:00:00 2001 From: Markus Stockhausen Date: Mon, 26 Jan 2026 14:34:07 +0100 Subject: [PATCH] realtek: phy: replace hard coded pages 30/31 with define Some of the code forgot to use the register defines for page selection. Replace the hard coded values with their define. Signed-off-by: Markus Stockhausen Link: https://github.com/openwrt/openwrt/pull/21716 Signed-off-by: Hauke Mehrtens --- .../files-6.12/drivers/net/phy/rtl83xx-phy.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.c b/target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.c index 475a628de9..428fdb7d53 100644 --- a/target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.c +++ b/target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.c @@ -127,18 +127,18 @@ static int rtl821x_match_phy_device(struct phy_device *phydev) * during detection. */ - oldpage = mdiobus_read(bus, addr, 0x1f); - oldxpage = mdiobus_read(bus, addr, 0x1e); + oldpage = mdiobus_read(bus, addr, RTL821x_PAGE_SELECT); + oldxpage = mdiobus_read(bus, addr, RTL821x_EXT_PAGE_SELECT); - mdiobus_write(bus, addr, 0x1e, 0x8); - mdiobus_write(bus, addr, 0x1f, 0x278); + mdiobus_write(bus, addr, RTL821x_EXT_PAGE_SELECT, 0x8); + mdiobus_write(bus, addr, RTL821x_PAGE_SELECT, 0x278); mdiobus_write(bus, addr, 0x12, 0x455); - mdiobus_write(bus, addr, 0x1f, 0x260); + mdiobus_write(bus, addr, RTL821x_PAGE_SELECT, 0x260); chip_mode = mdiobus_read(bus, addr, 0x12); dev_dbg(&phydev->mdio.dev, "got RTL8218B/RTL8214Fx chip mode %04x\n", chip_mode); - mdiobus_write(bus, addr, 0x1e, oldxpage); - mdiobus_write(bus, addr, 0x1f, oldpage); + mdiobus_write(bus, addr, RTL821x_EXT_PAGE_SELECT, oldxpage); + mdiobus_write(bus, addr, RTL821x_PAGE_SELECT, oldpage); /* no values while reading the 5th port during 5-8th port detection of RTL8218B */ if (!chip_mode)