mirror/openwrt
1
0
Fork 1
mirror of https://git.openwrt.org/openwrt/openwrt.git synced 2026-02-20 07:31:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

realtek: mdio: provide for_each_port helper

Browse source 
For better readability provide a macro to loop over all
active ports od the mdio bus.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/22008
Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit is contained in:
Markus Stockhausen 2026-02-13 20:25:15 +01:00 • committed by Robert Marko
parent afbbf21714
commit 60d90f9017
1 changed files with 8 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
target/linux/realtek/files-6.12/drivers/net/mdio/mdio-realtek-otto.c
View file

@ -104,6 +104,10 @@
#define RTMDIO_931X_SMI_10GPHY_POLLING_SEL3 (0x0CFC)
#define RTMDIO_931X_SMI_10GPHY_POLLING_SEL4 (0x0D00)
#define for_each_port(ctrl, addr) \
for (int addr = 0; addr < (ctrl)->cfg->cpu_port; addr++) \
if ((ctrl)->smi_bus[addr] >= 0)
/*
* On all Realtek switch platforms the hardware periodically reads the link status of all
* PHYs. This is to some degree programmable, so that one can tell the hardware to read
@ -566,10 +570,7 @@ static void rtmdio_setup_smi_topology(struct mii_bus *bus)
struct rtmdio_ctrl *ctrl = bus->priv;
u32 reg, mask, val;
for (int addr = 0; addr < ctrl->cfg->cpu_port; addr++) {
if (ctrl->smi_bus[addr] < 0)
continue;
for_each_port(ctrl, addr) {
if (ctrl->cfg->bus_map_base) {
reg = (addr / 16) * 4;
mask = 0x3 << ((addr % 16) * 2);
@ -719,10 +720,7 @@ static void rtmdio_930x_setup_polling(struct mii_bus *bus)
regmap_write(ctrl->map, RTMDIO_930X_SMI_MAC_TYPE_CTRL, 0);
/* Define PHY specific polling parameters */
for (int addr = 0; addr < ctrl->cfg->cpu_port; addr++) {
if (ctrl->smi_bus[addr] < 0)
continue;
for_each_port(ctrl, addr) {
rtmdio_get_phy_info(bus, addr, &phyinfo);
if (phyinfo.phy_unknown) {
pr_warn("skip polling setup for unknown PHY %08x on port %d\n",
@ -804,13 +802,10 @@ static void rtmdio_931x_setup_polling(struct mii_bus *bus)
* the existing hardware designs (i.e. only equally polled PHYs on
* the same SMI bus or kind of PHYs).
*/
for (int addr = 0; addr < ctrl->cfg->cpu_port; addr++) {
unsigned int mask, val;
for_each_port(ctrl, addr) {
int smi = ctrl->smi_bus[addr];
unsigned int mask, val;
if (smi < 0)
continue;
rtmdio_get_phy_info(bus, addr, &phyinfo);
if (phyinfo.phy_unknown) {
pr_warn("skip polling setup for unknown PHY %08x on port %d\n",