mirror/u-boot-2016
1
0
Fork 0
mirror of https://git.codelinaro.org/clo/qsdk/oss/boot/u-boot-2016.git synced 2025-12-10 07:44:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

net: macb: write mac address when initialization

Browse source 
When boot up without mac address setting, it will give the warning
message like: "Warning: failed to set MAC address", however when
execute network related command, it still execute them without any
warning information.

With this patch, it will exit directly with following information:
"gmac0: mac address is not valid"

It also solve the problem after bootup then set mac address and the
mac address won't set to net device issue.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
Tested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
This commit is contained in:
Bo Shen 2014-10-22 14:45:56 +08:00 • committed by Tom Rini
parent bdf790fabc
commit b2eff08869
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/net/macb.c
View file

@ -525,6 +525,7 @@ static int macb_phy_init(struct macb_device *macb)
return 1; return 1;
} }
static int macb_write_hwaddr(struct eth_device *dev);
static int macb_init(struct eth_device *netdev, bd_t *bd) static int macb_init(struct eth_device *netdev, bd_t *bd)
{ {
struct macb_device *macb = to_macb(netdev); struct macb_device *macb = to_macb(netdev);
@ -587,6 +588,14 @@ static int macb_init(struct eth_device *netdev, bd_t *bd)
#endif /* CONFIG_RMII */ #endif /* CONFIG_RMII */
} }
/* update the ethaddr */
if (is_valid_ether_addr(netdev->enetaddr)) {
macb_write_hwaddr(netdev);
} else {
printf("%s: mac address is not valid\n", netdev->name);
return -1;
}
if (!macb_phy_init(macb)) if (!macb_phy_init(macb))
return -1; return -1;