From 3d9a31733304f180963f9e0fe34c7ac9b67e3790 Mon Sep 17 00:00:00 2001 From: Varadarajan Narayanan Date: Thu, 15 Jun 2017 14:40:06 +0530 Subject: [PATCH] spi: qcom: Fix spi probe issue Cleared dynamically allocated region for spi global data to avoid garbage values causing data abort. Change-Id: Ie278cb3a1374d347d7dfb20b59059dfbf9a7ae42 Signed-off-by: Gokul Sriram Palanisamy --- drivers/spi/qca_qup_spi.c | 9 ++------- drivers/spi/qca_qup_spi_bam.c | 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/qca_qup_spi.c b/drivers/spi/qca_qup_spi.c index b95a4c65eb..8981f9933a 100644 --- a/drivers/spi/qca_qup_spi.c +++ b/drivers/spi/qca_qup_spi.c @@ -162,6 +162,8 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, return NULL; } + memset(ds, 0, sizeof(struct ipq_spi_slave)); + /* * QCA BLSP supports SPI Flash * on different BLSP0 and BLSP1 @@ -176,13 +178,6 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, } ds->slave.bus = bus; ds->slave.cs = cs; - - ds->slave.memory_map = NULL; - ds->slave.option = 0; - ds->slave.max_write_size = 0; - ds->slave.op_mode_rx = 0; - ds->slave.op_mode_tx = 0; - ds->regs = &spi_reg[bus]; /* TODO For different clock frequency */ diff --git a/drivers/spi/qca_qup_spi_bam.c b/drivers/spi/qca_qup_spi_bam.c index 75628c9543..3d695d8ef9 100644 --- a/drivers/spi/qca_qup_spi_bam.c +++ b/drivers/spi/qca_qup_spi_bam.c @@ -255,6 +255,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, return NULL; } + memset(ds, 0, sizeof(struct ipq_spi_slave)); /* * QCA BLSP supports SPI Flash * on different BLSP0 and BLSP1