Look for other possible "missing PICO_CONFIG" lines, and make message more obvious (#2477)
Some checks are pending
Bazel presubmit checks / bazel-build-check (macos-latest) (push) Waiting to run
Bazel presubmit checks / bazel-build-check (ubuntu-latest) (push) Waiting to run
Bazel presubmit checks / other-bazel-checks (push) Waiting to run
Check Configs / check-configs (push) Waiting to run
CMake / build (push) Waiting to run
Build on macOS / build (push) Waiting to run
Build on Windows / build (push) Waiting to run

This commit is contained in:
Andrew Scheller 2025-07-23 15:18:07 +01:00 committed by GitHub
parent 58d000f210
commit c650739c4c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -240,8 +240,9 @@ for all_configs in chips_all_configs.values():
chips_resolved_defines = defaultdict(dict) chips_resolved_defines = defaultdict(dict)
for applicable, all_defines in chips_all_defines.items(): for applicable, all_defines in chips_all_defines.items():
for d in all_defines: for d in all_defines:
if d not in all_config_names and d.startswith("PICO_"): for define_prefix in ('PICO', 'PARAM', 'CYW43'):
logger.warning("Potential unmarked PICO define {}".format(d)) if d not in all_config_names and d.startswith(define_prefix+'_'):
logger.warning("#define {} is potentially missing a {}: entry".format(d, BASE_CONFIG_NAME))
resolved_defines = chips_resolved_defines[applicable] resolved_defines = chips_resolved_defines[applicable]
# resolve "nested defines" - this allows e.g. USB_DPRAM_MAX to resolve to USB_DPRAM_SIZE which is set to 4096 (which then matches the relevant PICO_CONFIG entry) # resolve "nested defines" - this allows e.g. USB_DPRAM_MAX to resolve to USB_DPRAM_SIZE which is set to 4096 (which then matches the relevant PICO_CONFIG entry)
for val in all_defines[d]: for val in all_defines[d]: