mirror/pico-sdk
1
0
Fork 0
mirror of https://github.com/raspberrypi/pico-sdk.git synced 2025-12-10 07:14:36 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix always-true comparison warning in pio_insn (#2608)
Some checks failed
Bazel presubmit checks / bazel-build-check (macos-latest) (push) Has been cancelled
Details
Bazel presubmit checks / bazel-build-check (ubuntu-latest) (push) Has been cancelled
Details
Bazel presubmit checks / other-bazel-checks (push) Has been cancelled
Details
Check Configs / check-configs (push) Has been cancelled
Details
CMake / build (push) Has been cancelled
Details
Build on macOS / build (push) Has been cancelled
Details
Build on Windows / build (push) Has been cancelled
Details

Browse source 
The sideset_bit_count in pio_encode_sideset_opt is unsigned, so any comparison
"sideset_bit_count >= 0" will always be true.  GCC with pedantic warnings
will complain when this happens.

Remove the unneeded >=0 portion of the parameter validity check.

Fixes #2607
This commit is contained in:
Earle F. Philhower, III 2025-09-10 08:18:22 -07:00 • committed by GitHub
parent 4e1371f5fa
commit ad2f4143eb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/rp2_common/hardware_pio/include/hardware/pio_instructions.h
View file

@ -148,7 +148,7 @@ static inline uint pio_encode_sideset(uint sideset_bit_count, uint value) {
* \return the side set bits to be ORed with an instruction encoding
*/
static inline uint pio_encode_sideset_opt(uint sideset_bit_count, uint value) {
valid_params_if(PIO_INSTRUCTIONS, sideset_bit_count >= 0 && sideset_bit_count <= 4);
valid_params_if(PIO_INSTRUCTIONS, sideset_bit_count <= 4);
valid_params_if(PIO_INSTRUCTIONS, value <= ((1u << sideset_bit_count) - 1));
return 0x1000u | value << (12u - sideset_bit_count);
}