From 6e1b122c36d29d2e4df8dae330c526d41dc66d07 Mon Sep 17 00:00:00 2001
From: William Vinnicombe <william.vinnicombe@raspberrypi.com>
Date: Tue, 10 Mar 2026 13:08:16 +0000
Subject: [PATCH] Fix some returns

---
 src/common/pico_util/include/pico/util/bitset.h    | 1 +
 src/rp2_common/hardware_rtc/include/hardware/rtc.h | 3 ++-
 src/rp2_common/hardware_rtc/rtc.c                  | 4 ++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/common/pico_util/include/pico/util/bitset.h b/src/common/pico_util/include/pico/util/bitset.h
index 74bd94b8..f8ab21d2 100644
--- a/src/common/pico_util/include/pico/util/bitset.h
+++ b/src/common/pico_util/include/pico/util/bitset.h
@@ -66,6 +66,7 @@ static inline generic_bitset_t *bitset_write_word(generic_bitset_t *bitset, uint
     if (word_num < bitset_word_size(bitset)) {
         bitset->words[word_num] = value;
     }
+    return bitset;
 }
 
 static inline uint32_t bitset_read_word(const generic_bitset_t *bitset, uint word_num) {
diff --git a/src/rp2_common/hardware_rtc/include/hardware/rtc.h b/src/rp2_common/hardware_rtc/include/hardware/rtc.h
index 500c4ee4..6b5576c7 100644
--- a/src/rp2_common/hardware_rtc/include/hardware/rtc.h
+++ b/src/rp2_common/hardware_rtc/include/hardware/rtc.h
@@ -95,8 +95,9 @@ void rtc_disable_alarm(void);
  *
  * \param src_hz The frequency of the external clock source
  * \param gpio_pin The input pin providing the external clock (GP20 or GP22)
+ * \return true if it is possible to run the RTC from the external clock frequency, false otherwise.
  */
-void rtc_run_from_external_source(uint src_hz, uint gpio_pin);
+bool rtc_run_from_external_source(uint32_t src_hz, uint gpio_pin);
 
 #ifdef __cplusplus
 }
diff --git a/src/rp2_common/hardware_rtc/rtc.c b/src/rp2_common/hardware_rtc/rtc.c
index 1c056a82..faba578c 100644
--- a/src/rp2_common/hardware_rtc/rtc.c
+++ b/src/rp2_common/hardware_rtc/rtc.c
@@ -189,6 +189,6 @@ void rtc_disable_alarm(void) {
     }
 }
 
-void rtc_run_from_external_source(uint src_hz, uint gpio_pin) {
-    clock_configure_gpin(clk_rtc, gpio_pin, src_hz, 46875);
+bool rtc_run_from_external_source(uint32_t src_hz, uint gpio_pin) {
+    return clock_configure_gpin(clk_rtc, gpio_pin, src_hz, 46875);
 }
\ No newline at end of file