Release the lock in mbedtls_sha256_free if it was not released already (#2105)

* Release the lock in mbedtls_sha256_free if it was not released already. Requires making pico_sha256_unlock include-able. Fixes #2103.

* addres lock release API comment

* Fix description of pico_sha256_cleanup

---------

Co-authored-by: nils <nils@nils>
Co-authored-by: Peter Harper <peter.harper@raspberrypi.com>
This commit is contained in:
nilswiersma 2025-01-31 18:41:07 +01:00 committed by GitHub
parent 3d746b3fa7
commit 6c06f90bfe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 17 additions and 0 deletions

View file

@ -36,6 +36,7 @@ void mbedtls_sha256_init(__unused mbedtls_sha256_context *ctx) {
}
void mbedtls_sha256_free(__unused mbedtls_sha256_context *ctx) {
pico_sha256_cleanup(ctx);
}
int mbedtls_sha256_starts_ret(mbedtls_sha256_context *ctx, int is224) {

View file

@ -58,6 +58,16 @@ typedef struct pico_sha256_state {
size_t total_data_size;
} pico_sha256_state_t;
/*! \brief Release the internal lock on the SHA-256 hardware
* \ingroup pico_sha256
*
* Release the internal lock on the SHA-256 hardware.
* Does nothing if the internal lock was not claimed.
*
* @param state A pointer to a pico_sha256_state_t instance
*/
void pico_sha256_cleanup(pico_sha256_state_t *state);
/*! \brief Start a SHA-256 calculation returning immediately with an error if the SHA-256 hardware is not available
* \ingroup pico_sha256
*

View file

@ -30,6 +30,12 @@ void __weak pico_sha256_unlock(pico_sha256_state_t *state) {
state->locked = false;
}
void pico_sha256_cleanup(pico_sha256_state_t *state) {
if (state->locked) {
pico_sha256_unlock(state);
}
}
int pico_sha256_try_start(pico_sha256_state_t *state, enum sha256_endianness endianness, bool use_dma) {
memset(state, 0, sizeof(*state));
if (!pico_sha256_lock(state)) return PICO_ERROR_RESOURCE_IN_USE;