mirror/openwrt
1
0
Fork 1
mirror of https://git.openwrt.org/openwrt/openwrt.git synced 2026-02-14 13:39:05 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

realtek: pcs: rtl931x: drop unneeded cmu band read

Browse source 
There is still a stray call in setup_serdes to read the current CMU
band. The only effect is that the current band is printed to the log, the
value itself isn't used for anything further. Drop this since it's not
needed.

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/21858
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This commit is contained in:
Jonas Jelonek 2026-02-03 18:51:49 +00:00 • committed by Hauke Mehrtens
parent 31732b678e
commit eda2d44ebd
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
View file

@ -3340,6 +3340,7 @@ static int rtpcs_931x_sds_cmu_band_set(struct rtpcs_serdes *sds,
return 0;
}
__maybe_unused
static int rtpcs_931x_sds_cmu_band_get(struct rtpcs_serdes *sds,
enum rtpcs_sds_mode hw_mode)
{
@ -3593,7 +3594,7 @@ static int rtpcs_931x_setup_serdes(struct rtpcs_serdes *sds,
struct rtpcs_serdes *even_sds = rtpcs_sds_get_even(sds);
struct rtpcs_ctrl *ctrl = sds->ctrl;
u32 sds_id = sds->id;
u32 band, val;
u32 val;
int ret;
/*
@ -3629,9 +3630,6 @@ static int rtpcs_931x_setup_serdes(struct rtpcs_serdes *sds,
rtpcs_931x_sds_power(sds, false);
/* TODO: is this needed? */
band = rtpcs_931x_sds_cmu_band_get(sds, hw_mode);
ret = rtpcs_931x_sds_config_hw_mode(sds, hw_mode);
if (ret < 0)
return ret;