From dc78b80f4abf1994d15f23a6a63f34fc8860f441 Mon Sep 17 00:00:00 2001 From: Jonas Jelonek Date: Fri, 9 Jan 2026 23:43:21 +0000 Subject: [PATCH] realtek: phy: add comment to firmware file definition Add a comment stating the situation around a specific RTL838x firmware file. After SerDes setup has been moved to the PCS driver, this firmware file is partially unused. If the remaining bits are pulled out or just replaced, this firmware file can be dropped. The comment ensures that we do not forget about that. Signed-off-by: Jonas Jelonek Link: https://github.com/openwrt/openwrt/pull/21481 Signed-off-by: Robert Marko --- .../linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.h b/target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.h index c63d6174e1..e032d1301a 100644 --- a/target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.h +++ b/target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.h @@ -15,7 +15,14 @@ struct __packed fw_header { }; /* TODO: fixed path? */ +/* NOTE: This firmware file contains both patch values for SerDes + * configuration and for the internal RTL8218B PHY of RTL838x. Because + * the SerDes setup has been moved to the PCS driver and the firmware + * file isn't used there, this was only kept for the PHY. As soon as + * this has been changed, this firmware file can be dropped completely. + */ #define FIRMWARE_838X_8380_1 "rtl838x_phy/rtl838x_8380.fw" + #define FIRMWARE_838X_8214FC_1 "rtl838x_phy/rtl838x_8214fc.fw" #define FIRMWARE_838X_8218b_1 "rtl838x_phy/rtl838x_8218b.fw"