mirror/openwrt
1
0
Fork 1
mirror of https://git.openwrt.org/openwrt/openwrt.git synced 2026-03-04 00:14:04 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

realtek: mdio: rename foreach iterator

Browse source 
The driver covers phys and not ports. Adapt the iterator to
align with this naming convention. While we are here convert
some open coding to this iterator macro.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/22131
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This commit is contained in:
Markus Stockhausen 2026-02-21 09:30:40 +01:00 • committed by Hauke Mehrtens
parent 0b881a6976
commit d515b934aa
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
target/linux/realtek/files-6.12/drivers/net/mdio/mdio-realtek-otto.c
View file

@ -107,7 +107,7 @@
#define RTMDIO_931X_SMI_10GPHY_POLLING_SEL3 (0x0CFC)
#define RTMDIO_931X_SMI_10GPHY_POLLING_SEL4 (0x0D00)
#define for_each_port(ctrl, addr) \
#define for_each_phy(ctrl, addr) \
for (int addr = 0; addr < (ctrl)->cfg->num_phys; addr++) \
if ((ctrl)->smi_bus[addr] >= 0)
@ -567,7 +567,7 @@ static void rtmdio_setup_smi_topology(struct mii_bus *bus)
struct rtmdio_ctrl *ctrl = bus->priv;
u32 reg, mask, val;
for_each_port(ctrl, addr) {
for_each_phy(ctrl, addr) {
if (ctrl->cfg->bus_map_base) {
reg = (addr / 16) * 4;
mask = 0x3 << ((addr % 16) * 2);
@ -727,7 +727,7 @@ static void rtmdio_930x_setup_polling(struct mii_bus *bus)
regmap_write(ctrl->map, RTMDIO_930X_SMI_MAC_TYPE_CTRL, 0);
/* Define PHY specific polling parameters */
for_each_port(ctrl, addr) {
for_each_phy(ctrl, addr) {
if (rtmdio_get_phy_info(bus, addr, &phyinfo))
continue;
@ -804,7 +804,7 @@ static void rtmdio_931x_setup_polling(struct mii_bus *bus)
RTMDIO_931X_SMI_PHY_ABLTY_SDS * 0x55555555U);
/* Define PHY specific polling parameters */
for_each_port(ctrl, addr) {
for_each_phy(ctrl, addr) {
int smi = ctrl->smi_bus[addr];
unsigned int mask, val;
@ -938,10 +938,7 @@ static int rtmdio_probe(struct platform_device *pdev)
if (ret)
return ret;
for (addr = 0; addr < ctrl->cfg->num_phys; addr++) {
if (ctrl->smi_bus[addr] < 0)
continue;
for_each_phy(ctrl, addr) {
ret = fwnode_mdiobus_register_phy(bus, of_fwnode_handle(dn[addr]), addr);
of_node_put(dn[addr]);
if (ret)