mirror/openwrt
1
0
Fork 1
mirror of https://git.openwrt.org/openwrt/openwrt.git synced 2026-02-14 18:19:07 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

realtek: pcs: rtl931x: config CMU before media

Browse source 
Currently, the CMU is configured after media specific settings have been
set. This seems to work however does not make that much sense. The
proper clock should be configured before the TX/RX channels are
configured. Thus, move the call to the CMU configuration above the media
handling.

While at it, handle the return code of the CMU config properly.

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/21858
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This commit is contained in:
Jonas Jelonek 2026-02-02 22:48:04 +00:00 • committed by Hauke Mehrtens
parent 459b456185
commit b87db98aff
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
View file

@ -3620,6 +3620,10 @@ static int rtpcs_931x_setup_serdes(struct rtpcs_serdes *sds,
if (ret < 0)
return ret;
ret = rtpcs_931x_sds_config_cmu(sds, hw_mode);
if (ret < 0)
return ret;
switch (hw_mode) {
case RTPCS_SDS_MODE_OFF:
ret = rtpcs_931x_sds_set_port_media(sds, RTPCS_PORT_MEDIA_NONE);
@ -3638,8 +3642,6 @@ static int rtpcs_931x_setup_serdes(struct rtpcs_serdes *sds,
break;
}
rtpcs_931x_sds_config_cmu(sds, hw_mode);
if (sds_id >= 2) {
if (ctrl->chip_version == RTPCS_CHIP_V2)
/* consider 9311 etc. RTL9313_CHIP_ID == HWP_CHIP_ID(unit)) */