From 82dbd32e13b01731116988712e64957fe753ea5d Mon Sep 17 00:00:00 2001 From: Sander Vanheule Date: Sat, 21 Feb 2026 14:44:23 +0100 Subject: [PATCH] realtek: rtl838x: drop GS1900 MDIO reset GPIO The reset line wired to the RTL8231 on the GS1900 series may also connect to other external ICs on the board. On the GS1900-24E, the reset line is wired (via buffers) to the board's RTL8231 expanders and the RTL8218 phys. As these external devices (phys) are on different busses, the reset line shouldn't be specified on one bus or the other. Drop the reset specification from the generic GPIO description, so it can be added back on a per-device basis after confirming the behavior. Link: https://github.com/openwrt/openwrt/issues/18620 Fixes: fd978c2e80b4 ("realtek: Enable Zyxel GS1900's RTL8231 reset line") Signed-off-by: Sander Vanheule (cherry picked from commit cdbd9eb448a8fa802cbc2b2f8a1dec93b3999a3b) --- target/linux/realtek/dts/rtl8380_zyxel_gs1900_gpio.dtsi | 4 ---- .../linux/realtek/dts/rtl8380_zyxel_gs1900_gpio_emulated.dtsi | 4 ---- 2 files changed, 8 deletions(-) diff --git a/target/linux/realtek/dts/rtl8380_zyxel_gs1900_gpio.dtsi b/target/linux/realtek/dts/rtl8380_zyxel_gs1900_gpio.dtsi index 93ec7e4a1e..a4733dfec0 100644 --- a/target/linux/realtek/dts/rtl8380_zyxel_gs1900_gpio.dtsi +++ b/target/linux/realtek/dts/rtl8380_zyxel_gs1900_gpio.dtsi @@ -5,10 +5,6 @@ &mdio_aux { status = "okay"; - reset-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>; - reset-delay-us = <1000>; - reset-post-delay-us = <10000>; - gpio1: expander@0 { compatible = "realtek,rtl8231"; reg = <0x0>; diff --git a/target/linux/realtek/dts/rtl8380_zyxel_gs1900_gpio_emulated.dtsi b/target/linux/realtek/dts/rtl8380_zyxel_gs1900_gpio_emulated.dtsi index 70969eb00c..f98e404a3b 100644 --- a/target/linux/realtek/dts/rtl8380_zyxel_gs1900_gpio_emulated.dtsi +++ b/target/linux/realtek/dts/rtl8380_zyxel_gs1900_gpio_emulated.dtsi @@ -5,10 +5,6 @@ &mdio_gpio { status = "okay"; - reset-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>; - reset-delay-us = <1000>; - reset-post-delay-us = <10000>; - gpio1: expander@0 { compatible = "realtek,rtl8231"; reg = <0x0>;