From 4cf401088e325b0631c910dfa5ff80683d19093b Mon Sep 17 00:00:00 2001 From: Jonas Jelonek Date: Fri, 27 Feb 2026 23:24:29 +0000 Subject: [PATCH] realtek: dts: drop SYS LED of XikeStor SKS8310-8X The sys_led node in the device tree is wrong and doesn't work. On GPIO 23 nothing seems to be connected. The switch has a SYS LED but as with a lot other Realtek switches, this LED is connected to the pin A0, which can be driven as GPIO0 or system LED. The hardware-assisted behavior is configured during boot by u-boot. Though it is be possible to deactivate the hardware-assisted behavior and give userspace control over the LED, it doesn't work for this switch. XikeStor apparently decided to hook the SYS LED to some kind of external watchdog. This one seems to expect a LOW signal on that line periodically. This leaves room for two options: 1) keep behavior and let the LED blink as configured by u-boot 2) turn off LED completely Option 2) is rather odd and may confuse users, thus it is better to keep the behavior as-is for now. u-boot configures the LED to blink fast which might be annoying. As soon as we have a way in the device tree to specify different blinking frequencies as supported by the hardware, this can be smoothened. Signed-off-by: Jonas Jelonek Link: https://github.com/openwrt/openwrt/pull/22211 Signed-off-by: Hauke Mehrtens --- .../linux/realtek/dts/rtl9303_xikestor_sks8310-8x.dts | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/target/linux/realtek/dts/rtl9303_xikestor_sks8310-8x.dts b/target/linux/realtek/dts/rtl9303_xikestor_sks8310-8x.dts index feda833ff9..f5b6929978 100644 --- a/target/linux/realtek/dts/rtl9303_xikestor_sks8310-8x.dts +++ b/target/linux/realtek/dts/rtl9303_xikestor_sks8310-8x.dts @@ -34,16 +34,6 @@ }; }; - leds { - compatible = "gpio-leds"; - - led_sys: led-0 { - gpios = <&gpio0 23 GPIO_ACTIVE_HIGH>; - color = ; - function = LED_FUNCTION_STATUS; - }; - }; - led_set { compatible = "realtek,rtl9300-leds"; active-low;