From cdcc69a881125de5c2fad1cb5ec2b72be4479b6c Mon Sep 17 00:00:00 2001 From: Markus Gothe Date: Sat, 18 Feb 2023 21:46:14 +0100 Subject: [PATCH] gryphon-led-module: Improve error handling. For errors to propagte correctly we cannot set the pointer to NULL. Change-Id: Ie220f3dbe75b7eeefe2e0080279826c6b99144ef --- gryphon-led-module/src/main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gryphon-led-module/src/main.c b/gryphon-led-module/src/main.c index f97508619..af622416e 100644 --- a/gryphon-led-module/src/main.c +++ b/gryphon-led-module/src/main.c @@ -220,7 +220,6 @@ static int canyon_led_probe(struct platform_device *pdev) if (IS_ERR(leds->clock_gpio)) { dev_err(&pdev->dev, "Failed to acquire clock GPIO %ld\n", PTR_ERR(leds->clock_gpio)); - leds->clock_gpio = NULL; return PTR_ERR(leds->clock_gpio); } @@ -228,7 +227,6 @@ static int canyon_led_probe(struct platform_device *pdev) if (IS_ERR(leds->clock_gpio)) { dev_err(&pdev->dev, "Failed to acquire clock GPIO %ld\n", PTR_ERR(leds->clock_gpio)); - leds->clock_gpio = NULL; return PTR_ERR(leds->clock_gpio); } else { printk(KERN_INFO "Got clock gpio\n"); @@ -246,7 +244,6 @@ static int canyon_led_probe(struct platform_device *pdev) if (IS_ERR(leds->data_gpio)) { dev_err(&pdev->dev, "Failed to acquire data GPIO %ld\n", PTR_ERR(leds->data_gpio)); - leds->data_gpio = NULL; return PTR_ERR(leds->data_gpio); } @@ -254,7 +251,6 @@ static int canyon_led_probe(struct platform_device *pdev) if (IS_ERR(leds->data_gpio)) { dev_err(&pdev->dev, "Failed to acquire data GPIO %ld\n", PTR_ERR(leds->data_gpio)); - leds->data_gpio = NULL; return PTR_ERR(leds->data_gpio); } else { printk(KERN_INFO "Got data gpio\n");