icwmp: Code enhancement

icwmp/Makefile

@@ -8,11 +8,11 @@
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=icwmp
-PKG_VERSION:=8.1.9-2021-09-17
+PKG_VERSION:=8.1.10-2021-09-21
 PKG_FIXUP:=autoreconf
 PKG_SOURCE_URL:=https://dev.iopsys.eu/iopsys/icwmp.git
 PKG_SOURCE_PROTO:=git
-PKG_SOURCE_VERSION:=6a2ea866f3ce4e346db26e083589897312bcd41a
+PKG_SOURCE_VERSION:=2e55c12d13af617f9c5b1551e9d67287efd52715
 PKG_RELEASE=$(PKG_SOURCE_VERSION)
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION)-$(PKG_SOURCE_VERSION).tar.gz
 PKG_MIRROR_HASH:=skip
@@ -29,8 +29,6 @@ PKG_CONFIG_DEPENDS:= \
 
 PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(PKG_VERSION)
 
-CWMP_REVISION=$(shell svnversion ./src/ -n|cut -f2 -d:)
-
 include $(INCLUDE_DIR)/package.mk
 
 define Package/$(PKG_NAME)
@@ -57,24 +55,8 @@ endef
 endif
 
 TARGET_CFLAGS += \
-	-D_GNU_SOURCE -D_AADJ
-
-ifneq ($(CWMP_REVISION)_,_)
-ifneq ($(CWMP_REVISION),exported)
-ifneq ($(CWMP_REVISION),Unversioned directory)
-TARGET_CFLAGS += "-DCWMP_REVISION=\\\"$(CWMP_REVISION)\\\""
-TARGET_LDFLAGS += "-DCWMP_REVISION=\\\"$(CWMP_REVISION)\\\""
-endif
-endif
-endif
-
-TARGET_LDFLAGS += \
-	-Wl,-rpath-link=$(STAGING_DIR)/usr/lib
-
-CONFIGURE_ARGS += \
-	--with-uci-include-path=$(STAGING_DIR)/usr/include \
-	--with-libubox-include-path=$(STAGING_DIR)/usr/include \
-	--with-libubus-include-path=$(STAGING_DIR)/usr/include
+	-D_GNU_SOURCE \
+	"-DCWMP_REVISION=\\\"$(PKG_SOURCE_VERSION)\\\""
 
 ifeq ($(CONFIG_CWMP_ACS_MULTI),y)
 CONFIGURE_ARGS += \
@@ -99,26 +81,20 @@ endif
 define Package/$(PKG_NAME)/install
 	$(INSTALL_DIR) $(1)/etc/icwmpd
 	$(INSTALL_DIR) $(1)/usr/sbin
-	$(INSTALL_BIN) $(PKG_BUILD_DIR)/bin/icwmpd $(1)/usr/sbin/
-	$(CP) ./files/* $(1)/
-endef
-
-define Package/$(PKG_NAME)/postinst
-	#!/bin/sh
-	if [ -z "$${IPKG_INSTROOT}" ]; then
-		echo "Enabling rc.d symlink for icwmpd"
-		/etc/init.d/icwmpd enable
-	fi
-	exit 0
-endef
-
-define Package/$(PKG_NAME)/prerm
-	#!/bin/sh
-	if [ -z "$${IPKG_INSTROOT}" ]; then
-		echo "Disabling rc.d symlink for icwmpd"
-		/etc/init.d/icwmpd disable
-	fi
-	exit 0
+	$(INSTALL_DIR) $(1)/etc/config
+	$(INSTALL_DIR) $(1)/etc/hotplug.d/iface
+	$(INSTALL_DIR) $(1)/etc/init.d
+	$(INSTALL_DIR) $(1)/etc/uci-defaults
+	$(INSTALL_DIR) $(1)/lib/upgrade/keep.d
+	$(INSTALL_BIN) $(PKG_BUILD_DIR)/bin/icwmpd $(1)/usr/sbin/icwmpd
+	$(INSTALL_DATA) ./files/etc/config/cwmp $(1)/etc/config/cwmp
+	$(INSTALL_BIN) ./files/etc/firewall.cwmp $(1)/etc/firewall.cwmp
+	$(INSTALL_BIN) ./files/etc/hotplug.d/iface/90-icwmp $(1)/etc/hotplug.d/iface/90-icwmp
+	$(INSTALL_BIN) ./files/etc/init.d/icwmpd $(1)/etc/init.d/icwmpd
+	$(INSTALL_BIN) ./files/etc/uci-defaults/85-cwmp-set-userid $(1)/etc/uci-defaults/
+	$(INSTALL_BIN) ./files/etc/uci-defaults/90-cwmpfirewall $(1)/etc/uci-defaults/
+	$(INSTALL_BIN) ./files/etc/uci-defaults/90-icwmp-set-dhcp-reqopts $(1)/etc/uci-defaults/
+	$(INSTALL_DATA) ./files/lib/upgrade/keep.d/icwmp $(1)/lib/upgrade/keep.d/icwmp
 endef
 
 $(eval $(call BuildPackage,$(PKG_NAME)))

icwmp/files/etc/hotplug.d/iface/90-icwmp

@@ -81,6 +81,8 @@ handle_icwmp_restart() {
 		[ -z "$prevopt43url" ] && exit 0
 	}
 
+	echo "Restarting icwmp"|logger -t cwmp.hotplug -p info
+
 	/etc/init.d/icwmpd reload &
 }
 

icwmp/files/etc/init.d/icwmpd

@@ -169,6 +169,9 @@ start_service() {
 		[ -f /etc/config/dhcp ] && log "Waiting for DNS Server(s) ..." && wait_for_resolvfile 20
 		[ -f /usr/sbin/asterisk ] && log "Waiting for Voice to be started ..." && ubus -t 5 wait_for asterisk
 
+		log "Waiting for usp.raw to be started"
+		ubus wait_for usp.raw
+
 		config_load cwmp
 		set_wan_interface
 		wait_for_option43 20