From 506429fdfe51060cb6fd0bb2b3f23e7517f1d601 Mon Sep 17 00:00:00 2001 From: Amin Ben Romdhane Date: Tue, 23 Apr 2024 16:59:09 +0200 Subject: [PATCH] Fix memory leaks --- src/autonomous_complpolicy.c | 10 ++++++++-- src/download.c | 1 + src/upload.c | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/autonomous_complpolicy.c b/src/autonomous_complpolicy.c index 8bb723d..5cebadc 100644 --- a/src/autonomous_complpolicy.c +++ b/src/autonomous_complpolicy.c @@ -86,7 +86,10 @@ static void send_du_state_change_notif(struct blob_attr *msg) if (tb[1]) { char *uuid = NULL, *oper = NULL; - CWMP_LOG(INFO, "%s\n", blobmsg_format_json_indent(tb[1], true, -1)); + char *str = blobmsg_format_json_indent(tb[1], true, -1); + CWMP_LOG(INFO, "%s\n", str); + FREE(str); + struct blob_attr *tb1[9] = {NULL}; blobmsg_parse(p1, 9, tb1, blobmsg_data(tb[1]), blobmsg_len(tb[1])); @@ -217,7 +220,10 @@ static void send_transfer_complete_notif(struct blob_attr *msg) if (tb[1]) { char file_type[256] = {0}; - CWMP_LOG(INFO, "%s\n", blobmsg_format_json_indent(tb[1], true, -1)); + char *str = blobmsg_format_json_indent(tb[1], true, -1); + CWMP_LOG(INFO, "%s\n", str); + FREE(str); + struct blob_attr *tb1[10] = {NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL}; blobmsg_parse(p1, 6, tb1, blobmsg_data(tb[1]), blobmsg_len(tb[1])); diff --git a/src/download.c b/src/download.c index cbaa0f1..64466bb 100644 --- a/src/download.c +++ b/src/download.c @@ -134,6 +134,7 @@ int download_file_in_subprocess(const char *file_path, const char *url, const ch if (download_task != NULL) { char *ret = execute_task_in_subprocess(download_task); + FREE(download_task); return ret ? atoi(ret) : 500; } diff --git a/src/upload.c b/src/upload.c index 63c092c..270cf9d 100644 --- a/src/upload.c +++ b/src/upload.c @@ -196,6 +196,7 @@ int upload_file_in_subprocess(const char *file_path, const char *url, const char if (upload_task != NULL) { char *ret = execute_task_in_subprocess(upload_task); + FREE(upload_task); return ret ? atoi(ret) : 500; } return 500;