From 4a91657fe8e2e0658176d4cd7957c06eddd5f9a0 Mon Sep 17 00:00:00 2001
From: Suvendhu Hansa <suvendhu.hansa@iopsys.eu>
Date: Thu, 5 Feb 2026 11:32:49 +0530
Subject: [PATCH] Fix static analysis

---
 src/common.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/common.c b/src/common.c
index 64b045e..d286bdc 100755
--- a/src/common.c
+++ b/src/common.c
@@ -725,10 +725,16 @@ void icwmp_init_critical_services()
 				if (ret == true)
 					continue;
 
-				serv = (struct cwmp_services *)malloc(sizeof(struct cwmp_services));
+				serv = (struct cwmp_services *)calloc(1, sizeof(struct cwmp_services));
 				if (serv) {
-					list_add_tail(&serv->list, &critical_service_list);
 					serv->service = CWMP_STRDUP(config_name);
+					if (serv->service == NULL) {
+						free(serv);
+						continue;
+					}
+
+					INIT_LIST_HEAD(&serv->list);
+					list_add_tail(&serv->list, &critical_service_list);
 				}
 			}
 			break;