mirror of
https://dev.iopsys.eu/bbf/bbfdm.git
synced 2026-01-28 01:47:18 +01:00
df25ff7ce0
When using macros, both any occurence of arguments and the macro itself have to be enclosed in parenthesis to prevent unintended behaviour with operator precedence. For now, only fix the one causing a -Wint-conversion warning in GCC 14 when using constructs like these, where two macros are used together and expand to both two comparisons and two nested ternary expression. dhcpmngr.c:502:41: error: pointer/integer type mismatch in conditional expression [-Wint-conversion] 502 | if (DM_STRCMP(parent_s, section_name(s)) != 0) Given the very heavy use of macros in this project, there are probably more instances of this issue in the code and it can cause actual logic errors. While at it, double evaluation should also be checked for. Link: http://web.archive.org/web/20140127211232/http://docs.freebsd.org/info/cpp/cpp.info.Macro_Parentheses.html Link: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html Signed-off-by: Andreas Gnau <andreas.gnau@iopsys.eu> |
||
|---|---|---|
| .. | ||
| include | ||
| plugin | ||
| CMakeLists.txt | ||
| dmapi.c | ||
| dmapi.h | ||
| dmbbf.c | ||
| dmbbf.h | ||
| dmcommon.c | ||
| dmcommon.h | ||
| dmentry.c | ||
| dmentry.h | ||
| dmjson.c | ||
| dmjson.h | ||
| dmmem.c | ||
| dmmem.h | ||
| dmplugin.c | ||
| dmplugin.h | ||
| dmubus.c | ||
| dmubus.h | ||
| dmuci.c | ||
| dmuci.h | ||