- Fix memleak of not free'd json_tokener_parse memory
- Make read-only memory const
Note that this commit changes the operation input argument from
'char *' to 'json_object *', which breaks older dynamic_operate
implementations from outisde the bbf source tree.
Signed-off-by: Daniel Danzberger <daniel@dd-wrt.com>
- Move missing mcast functions from dmcommon file to mcast file
- Remove extern from function declarations
- Fix some indentation
- Comment unsupported parameters
- Obuspa required to register the schema present in DUT, in the
current methods, for multi-instance objects the instance is only
visible if at-least one object/instance present, this leads to
anomaly in obuspa, when some objects getting created in run-time.
e.g: Device.WiFi.AccessPoint.1.AssociatedDevice.
- This change will dump the complete schema irrespective of that node/object
availability.
It was observed on dg400prime that the uci config was not correctly
generated when wan was of type anywan, this has been taken care of in
this patch. For anywan type IP interface, the list of upstream interfaces
is generated to keep each interface in mind. So, Device.IP.Interface.2
in this case will generate
list upstream_interface 'eth5.1'
list upstream_interface 'atm0.1'
list upstream_interface 'ptm0.1'
test:
- Verify that config is correctly generated for normal interface.
- Verify that config is correctly generated for anywan interface.
- Verify that config is correctly generated for bridge interface.
Calling this dm_strword with an emtpy 'str' can cause invalid memory
access. This commit checks for an empty string.
NOTE: This function is insecure and can cause segfaults
when 'str' is larger than 'source'
Signed-off-by: Daniel Danzberger <daniel@dd-wrt.com>
For the changes done in branch, some changes in dmcommon were overwritten
accidentally, reverting the same. Only leaves snooping mode related
changes in the branch now.
Added support for MLD configuration using the new proposed data
model.
Resolve bug in IGMP to be able to delete child objects when
parents are deleted from the dmmap_mcast file.
Remove the hard coded value of Filter.Enable and added configuration
support for the same.
Note: With this, I think I am ready to raise merge request for this,
I will finalise the mcastmngr changes now and then raise a merge request
once that is in iopsys devel
Changes done are:
1. Interfaces in the proxy uci section are called upstream_interface
and downstream_interface as against proxy_interface and snooping_interface
earlier.
2. The interface now bears the value of the actual linux interface, so,
the upstream interface for example is now eth4.1 instead of wan.
3. A bug in the determining of bridging instance was identified and fixed.
The UCI looks as follows now:
root@iopsys:~# cat /etc/config/mcast
config proxy 'mproxy_1'
option enable '0'
option proto 'igmp'
option version '2'
option robustness '2'
option aggregation '0'
option last_member_query_interval '10'
option query_interval '120'
option query_response_interval '10'
list downstream_interface 'br-wan100'
list upstream_interface 'eth4.1'
config snooping 'msnoop_1'
option enable '0'
option proto 'igmp'
option version '2'
option robustness '2'
option aggregation '0'
option interface 'br-wan100'
