From 5c1a146fdb8123d38cf2e074d9a4103ab6ed34ff Mon Sep 17 00:00:00 2001 From: Grzegorz Sluja Date: Thu, 22 Jul 2021 14:42:30 +0200 Subject: [PATCH] VoiceService: Change SessionId parameters to DMT_STRING SessionId in cdr records can have negative value while we used unsigned int type for the following corresponding parameters: Device.Services.VoiceService.{i}.CallLog.{i}.Session.{i}.SessionID Device.Services.VoiceService.{i}.CallLog.{i}.BBF_VENDOR_PREFIX_SIPSession-ID Change it to DMT_STRING according to TR-104 standard. Signed-off-by: Grzegorz Sluja --- dmtree/tr104/servicesvoiceservicecalllog.c | 2 +- dmtree/vendor/iopsys/tr104/servicesvoiceservicecalllog.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dmtree/tr104/servicesvoiceservicecalllog.c b/dmtree/tr104/servicesvoiceservicecalllog.c index 8a0262e0..86627f7b 100644 --- a/dmtree/tr104/servicesvoiceservicecalllog.c +++ b/dmtree/tr104/servicesvoiceservicecalllog.c @@ -229,7 +229,7 @@ DMLEAF tServicesVoiceServiceCallLogSessionParams[] = { /* PARAM, permission, type, getvalue, setvalue, bbfdm_type*/ {"Duration", &DMREAD, DMT_UNINT, get_ServicesVoiceServiceCallLog_Duration, NULL, BBFDM_BOTH}, {"Start", &DMREAD, DMT_TIME, get_ServicesVoiceServiceCallLog_Start, NULL, BBFDM_BOTH}, -{"SessionID", &DMREAD, DMT_UNINT, get_ServicesVoiceServiceCallLog_SessionId, NULL, BBFDM_BOTH}, +{"SessionID", &DMREAD, DMT_STRING, get_ServicesVoiceServiceCallLog_SessionId, NULL, BBFDM_BOTH}, {0} }; diff --git a/dmtree/vendor/iopsys/tr104/servicesvoiceservicecalllog.c b/dmtree/vendor/iopsys/tr104/servicesvoiceservicecalllog.c index 0a94bfd4..14d4e679 100644 --- a/dmtree/vendor/iopsys/tr104/servicesvoiceservicecalllog.c +++ b/dmtree/vendor/iopsys/tr104/servicesvoiceservicecalllog.c @@ -151,7 +151,7 @@ static int get_ServicesVoiceServiceCallLog_Dst_PeakJitter(char *refparam, struct /* *** Device.Services.VoiceService.{i}.CallLog.{i}. *** */ DMLEAF tIOPSYS_VoiceServiceCallLogParams[] = { /* PARAM, permission, type, getvalue, setvalue, bbfdm_type*/ -{BBF_VENDOR_PREFIX"SIPSession-ID", &DMREAD, DMT_UNINT, get_ServicesVoiceServiceCallLog_SessionId, NULL, BBFDM_BOTH}, +{BBF_VENDOR_PREFIX"SIPSession-ID", &DMREAD, DMT_STRING, get_ServicesVoiceServiceCallLog_SessionId, NULL, BBFDM_BOTH}, {BBF_VENDOR_PREFIX"SIPIPAddress", &DMREAD, DMT_STRING, get_ServicesVoiceServiceCallLog_SipIpAddress, NULL, BBFDM_BOTH}, {BBF_VENDOR_PREFIX"SIPResponseCode", &DMREAD, DMT_UNINT, get_ServicesVoiceServiceCallLog_SipResponseCode, NULL, BBFDM_BOTH}, {0}