mirror/bbfdm
1
0
Fork 0
mirror of https://dev.iopsys.eu/bbf/bbfdm.git synced 2026-03-01 17:35:33 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix get_USB_InterfaceNumberOfEntries memory issues

Browse source 
- Fix Leaking on buffer allocation by using stack buffer
- Fix access on uninitalized and not zero terminated string returnd from
readlink()

Signed-off-by: Daniel Danzberger <daniel@dd-wrt.com>
This commit is contained in:
Daniel Danzberger 2020-01-04 15:03:29 +01:00
parent ef6f0cafe4
commit 313cb9921c
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
dmtree/tr181/usb.c
View file

@ -429,20 +429,23 @@ int get_USB_InterfaceNumberOfEntries(char *refparam, struct dmctx *ctx, void *da
{
DIR *dir;
struct dirent *ent;
char filename[100];
char *buffer= NULL;
int size = 100;
char filename[128];
char buffer[64];
int nbre= 0;
ssize_t rc;
if ((dir = opendir ("/sys/class/net")) == NULL)
return 0;
while ((ent = readdir (dir)) != NULL) {
buffer= (char*)dmmalloc(100*sizeof(char));
snprintf(filename, sizeof(filename), "/sys/class/net/%s", ent->d_name);
readlink (filename, buffer, size);
if(strstr(buffer, "/usb") == NULL)
continue;
nbre++;
sprintf(filename, "/sys/class/net/%s", ent->d_name);
rc = readlink (filename, buffer, sizeof(buffer) - 1);
if (rc > 0) {
buffer[rc] = 0;
if(!strstr(buffer, "/usb") == NULL)
nbre++;
}
}
dmasprintf(value, "%d", nbre);
return 0;