1
0
Fork 0
forked from mirror/openwrt
openwrt/target/linux/generic/files/drivers
Rafał Miłecki 981f5f7e40 kernel: fix refcnt leak in LED netdev trigger on interface rename
Renaming a netdev-trigger-tracked interface was resulting in an
unbalanced dev_hold().

Example:
> iw phy phy0 interface add foo type __ap
> echo netdev > trigger
> echo foo > device_name
> ip link set foo name bar
> iw dev bar del
[  237.355366] unregister_netdevice: waiting for bar to become free. Usage count = 1
[  247.435362] unregister_netdevice: waiting for bar to become free. Usage count = 1
[  257.545366] unregister_netdevice: waiting for bar to become free. Usage count = 1

Above problem was caused by trigger checking a dev->name which obviously
changes after renaming an interface. It meant missing all further events
including the NETDEV_UNREGISTER which is required for calling dev_put().

This change fixes that by:
1) Comparing device struct *address* for notification-filtering purposes
2) Dropping unneeded NETDEV_CHANGENAME code (no behavior change)

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
(cherry picked from commit eea538204b)
2019-03-06 06:12:39 +01:00
..
leds kernel: fix refcnt leak in LED netdev trigger on interface rename 2019-03-06 06:12:39 +01:00
misc kernel: owl-loader for delayed Atheros ath9k fixup 2016-09-19 19:32:35 +02:00
mtd ar71xx: Add support for Netgear WNR2000v1 2016-12-14 10:37:01 +01:00
net/phy ip17xx: correct aneg_done return value 2017-12-13 15:53:16 +01:00