arne/openwrt
1
0
Fork 0
forked from mirror/openwrt
Code Pull requests Activity

hostapd: fix memory leak in rrm ubus interface

Browse source 
Add missing wpabuf_free calls to the hostapd_rrm_nr_set and
hostapd_rrm_beacon_req functions.

Signed-off-by: Vladimir Palevich <palevichva@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/22538
Signed-off-by: Nick Hainke <vincent@systemli.org>
This commit is contained in:
Vladimir Palevich 2026-03-20 21:46:04 +01:00 • committed by Nick Hainke
parent 283c45f087
commit fde5d2e210
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
package/network/services/hostapd/src/src/ap/ubus.c
View file

@ -1123,9 +1123,9 @@ hostapd_rrm_nr_set(struct ubus_context *ctx, struct ubus_object *obj,
if (strlen(s) == 0) {
/* Copy BSSID from neighbor report */
if (hwaddr_compact_aton(nr_s, bssid))
goto invalid;
goto invalid_free;
} else if (hwaddr_aton(s, bssid)) {
goto invalid;
goto invalid_free;
}
/* SSID */
@ -1136,7 +1136,7 @@ hostapd_rrm_nr_set(struct ubus_context *ctx, struct ubus_object *obj,
} else {
ssid.ssid_len = strlen(s);
if (ssid.ssid_len > sizeof(ssid.ssid))
goto invalid;
goto invalid_free;
memcpy(&ssid, s, ssid.ssid_len);
}
@ -1145,6 +1145,8 @@ hostapd_rrm_nr_set(struct ubus_context *ctx, struct ubus_object *obj,
wpabuf_free(data);
continue;
invalid_free:
wpabuf_free(data);
invalid:
return UBUS_STATUS_INVALID_ARGUMENT;
}
@ -1252,6 +1254,7 @@ hostapd_rrm_beacon_req(struct ubus_context *ctx, struct ubus_object *obj,
}
ret = hostapd_send_beacon_req(hapd, addr, 0, req);
wpabuf_free(req);
if (ret < 0)
return -ret;