arne/openwrt
1
0
Fork 0
forked from mirror/openwrt
Code Pull requests Activity

mediatek: filogic: fix supported_devices list for gl-mt2500

Browse source 
The SUPPORTED_DEVICES sets for both Maxlinear (v1) and Airoha (v2)
devices were identical, so sysupgrade was unable to detect when an
incorrect image was being installed.  This caused "soft bricking" of
devices when a v1 image was installed on a v2 device, and vice versa.

Fix this by making the supported_devices distinct for each device
version, by renaming the devices with a version-specific name.
This is reflected in the file name and the image metadata.

Fixes: https://github.com/openwrt/openwrt/issues/20566
Fixes: https://github.com/openwrt/asu/issues/1525
Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/20632
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This commit is contained in:
Eric Fahlgren 2025-11-03 12:34:37 -08:00 • committed by Hauke Mehrtens
parent 3af16b2359
commit b71f4665cd
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
target/linux/mediatek/image/filogic.mk
View file

@ -1379,7 +1379,7 @@ define Device/glinet_gl-mt2500
DEVICE_DTS_DIR := ../dts DEVICE_DTS_DIR := ../dts
DEVICE_DTS_LOADADDR := 0x47000000 DEVICE_DTS_LOADADDR := 0x47000000
DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3 DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3
SUPPORTED_DEVICES += glinet,mt2500-emmc glinet,gl-mt2500-airoha SUPPORTED_DEVICES += glinet,mt2500-emmc
IMAGES := sysupgrade.bin factory.bin IMAGES := sysupgrade.bin factory.bin
IMAGE/factory.bin := append-kernel | pad-to 32M | append-rootfs IMAGE/factory.bin := append-kernel | pad-to 32M | append-rootfs
IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata
@ -1397,7 +1397,7 @@ define Device/glinet_gl-mt2500-airoha
DEVICE_DTS_DIR := ../dts DEVICE_DTS_DIR := ../dts
DEVICE_DTS_LOADADDR := 0x47000000 DEVICE_DTS_LOADADDR := 0x47000000
DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3 kmod-phy-airoha-en8811h airoha-en8811h-firmware DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3 kmod-phy-airoha-en8811h airoha-en8811h-firmware
SUPPORTED_DEVICES += glinet,mt2500-emmc glinet,gl-mt2500 SUPPORTED_DEVICES += glinet,mt2500-emmc
IMAGES := sysupgrade.bin IMAGES := sysupgrade.bin
IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata
endef endef